Page MenuHome

BLO: Use blender::Map in OldNewMap.
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Nov 18 2022, 6:24 PM.

Details

Summary

OldNewMap used to have its own map implementation. Given that the file uses C++ now, it is easy to use a C++ map implementation instead. This simplifies the code a lot.

Going forward it might make sense to remove the OldNewMap abstraction or to split it up in two (currently, NewAddress.nr has two different meanings in different contexts which is confusing).

No functional changes are expected.

Diff Detail

Repository
rB Blender
Branch
old-new-map-refactor (branched from master)
Build Status
Buildable 24726
Build 24726: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 18 2022, 6:24 PM
Jacques Lucke (JacquesLucke) created this revision.

Big +1

Just out of curiosity. did you check if there was any measurable performances difference?

This revision is now accepted and ready to land.Nov 28 2022, 4:38 PM

Just out of curiosity. did you check if there was any measurable performances difference?

I tried to measure it, but in any reasonable large file there was so much noise that I couldn't measure a performance difference with this patch.

This revision was automatically updated to reflect the committed changes.