Paths

Table of Contentst

Differential D16546

BLO: Use blender::Map in OldNewMap.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 18 2022, 6:24 PM.

Tags

None

Subscribers

None

Details

Reviewers

Bastien Montagne (mont29)

Commits

rB57613630c7fa: BLO: use blender::Map in OldNewMap

Summary

OldNewMap used to have its own map implementation. Given that the file uses C++ now, it is easy to use a C++ map implementation instead. This simplifies the code a lot.

Going forward it might make sense to remove the OldNewMap abstraction or to split it up in two (currently, NewAddress.nr has two different meanings in different contexts which is confusing).

No functional changes are expected.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 18 2022, 6:24 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B24726: Diff 57784.Nov 18 2022, 6:24 PM

https://builder.blender.org/admin/#/builders/136/builds/235

Jacques Lucke (JacquesLucke) added a reviewer: Bastien Montagne (mont29).Nov 18 2022, 6:29 PM

Big +1

Just out of curiosity. did you check if there was any measurable performances difference?

This revision is now accepted and ready to land.Nov 28 2022, 4:38 PM

Just out of curiosity. did you check if there was any measurable performances difference?

I tried to measure it, but in any reasonable large file there was so much noise that I couldn't measure a performance difference with this patch.

Closed by commit rB57613630c7fa: BLO: use blender::Map in OldNewMap (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 29 2022, 4:26 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB57613630c7fa: BLO: use blender::Map in OldNewMap.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

164 lines

Diff 58147

source/blender/blenloader/intern/readfile.cc

Loading...