Cleanup: Geometry Node: Image Texture
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Nov 18 2022, 6:51 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Hans Goudey (HooglyBoogly)

Commits

Summary

Cleanup: Geometry Node: Image Texture

While trying to implement T102289: Image Texture sampling by int X and Y pixel indices,
I noticed that this node has several solutions that are very different from other, newer nodes.
This patch will add:

Generally looks like a slight improvement, just a couple notes

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc
50–59	`uint8_t` -> `int8_t`
387–390	`vector_field` wasn't const because we use `std::move` on it. I think that will give an error on some compilers

Iliya Katueshenock (Moder) marked 2 inline comments as done.

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc
387–390	Ah, so here's the thing. Yes, I do not have an error, but it sounds logical, since the transfer of rights takes ownership and the fact of having. I didn't think about it.

This revision is now accepted and ready to land.Nov 21 2022, 6:01 PM

This revision was automatically updated to reflect the committed changes.