Page MenuHome

Image Info docs page
ClosedPublic

Authored by Iliya Katueshenock (Moder) on Nov 18 2022, 10:54 PM.

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Nov 18 2022, 10:54 PM
Iliya Katueshenock (Moder) created this revision.
Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 18 2022, 11:01 PM

Thanks for working on the docs page, I appreciate that!

manual/modeling/geometry_nodes/input/image_info.rst
5–7
15

"random" has different connotations that don't quite fit here, it suggests which image is use doesn't matter

21
30
36

The periods aren't necessary on the socket names

43
This revision now requires changes to proceed.Nov 18 2022, 11:01 PM
Iliya Katueshenock (Moder) planned changes to this revision.Nov 18 2022, 11:02 PM
Iliya Katueshenock (Moder) updated this revision to Diff 57805.
Iliya Katueshenock (Moder) marked 6 inline comments as done.
This revision is now accepted and ready to land.Nov 18 2022, 11:30 PM
  • Change example image size

Can you upload the node image in a comment please?

Yes, sorry for the delay. It seemed to me that this was still contained in the diff, although it was even written about in the manual (I had never seen such a uploading in other patches before)

Leon Schittek (lone_noel) added inline comments.
manual/modeling/geometry_nodes/input/image_info.rst
39

typo :)

Iliya Katueshenock (Moder) marked an inline comment as done.

Yes, thx that noticed it

Yes, sorry for the delay. It seemed to me that this was still contained in the diff, although it was even written about in the manual (I had never seen such a uploading in other patches before)

Yeah this is because there is no binary support in this patch system like there is on other patch review platforms.


I will get this committed to the 3.5 manual right away.

This revision was automatically updated to reflect the committed changes.