Page MenuHome
Differential D16561

Cycles: use more PMJ patterns and make their size adaptive.
ClosedPublic
Actions

Authored by Nathan Vegdahl (cessen) on Nov 20 2022, 6:19 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB03b5be4e3cdf: Cycles: use more PMJ patterns and make their size adaptive.
Summary

This resolves some issues with correlation artifacts at higher
sample counts. See T101356

Diff Detail

Repository
rB Blender

Event Timeline

Nathan Vegdahl (cessen) requested review of this revision.Nov 20 2022, 6:19 AM
Nathan Vegdahl (cessen) created this revision.
Harbormaster completed remote builds in B24747: Diff 57846.Nov 20 2022, 6:19 AM
Nathan Vegdahl (cessen) edited the summary of this revision. (Show Details)Nov 20 2022, 6:19 AM
Nathan Vegdahl (cessen) added a reviewer: Brecht Van Lommel (brecht).
Nathan Vegdahl (cessen) added projects: Cycles, Render & Cycles.

I'm not totally sure I've done everything here correctly, particularly in terms of handling alloc/free and passing the pattern size around.

Nathan Vegdahl (cessen) mentioned this in T101356: New PMJ does not converge to the same result as Sobol-Burley.Nov 20 2022, 6:24 AM
Alaska (Alaska) added a subscriber: Alaska (Alaska).EditedNov 20 2022, 10:22 AM

Sorry for nit-picking.
In intern/cycles/kernel/sample/jitter.h on line 19 you have:
/* NUM_TAB_SOBOL_SAMPLES should be a power of two... */
Shouldn't it be NUM_PMJ_SAMPLES since we haven't switched over to tabulated Sobol yet?

Nathan Vegdahl (cessen) added a comment.Nov 20 2022, 7:14 PM

Gah! Yes, thanks for catching that. Copy-paste mistake.

Nathan Vegdahl (cessen) updated this revision to Diff 57856.Nov 20 2022, 7:19 PM
  • Fix copy-paste error in comment.
  • Run clang-format.
Harbormaster completed remote builds in B24753: Diff 57856.Nov 20 2022, 7:19 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 21 2022, 7:08 PM

Seems to work well in my tests, including converging to consistent result with test file from T101356.

This revision is now accepted and ready to land.Nov 21 2022, 7:08 PM
Closed by commit rB03b5be4e3cdf: Cycles: use more PMJ patterns and make their size adaptive. (authored by Nathan Vegdahl (cessen), committed by Brecht Van Lommel (brecht)). · Explain WhyNov 21 2022, 7:20 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB03b5be4e3cdf: Cycles: use more PMJ patterns and make their size adaptive..
Brecht Van Lommel (brecht) mentioned this in D16443: Cycles: switch from pretabulated 2D PMJ02 to pretabulated 4D Sobol..Nov 21 2022, 7:23 PM
Brecht Van Lommel (brecht) mentioned this in rBL63104: Cycles: update reference images for more PMJ patterns.Nov 21 2022, 7:33 PM
Nathan Vegdahl (cessen) mentioned this in D16726: Limit the internal sample index of Sobol-Burley for faster sample generation..Dec 8 2022, 11:24 PM
Brecht Van Lommel (brecht) mentioned this in rBd9192aaa6d2a: Cycles: limit the internal sample index of Sobol-Burley for performance.Dec 14 2022, 5:51 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
6 lines
sample/
55 lines
9 lines
scene/
14 lines

Diff 57888

View Options

intern/cycles/kernel/data_template.h

Loading...
View Options

intern/cycles/kernel/sample/jitter.h

Loading...
View Options

intern/cycles/kernel/types.h

Loading...
View Options

intern/cycles/scene/integrator.cpp

Loading...