Page MenuHome
Differential D16583

Fix T102436: Crash using any Filter when automasking options are activated
AbandonedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Nov 22 2022, 8:00 PM.

Details

Reviewers
Joseph Eagar (joeedh)
Julien Kaspar (JulienKaspar)
Maniphest Tasks
T102436: Crash using any Filter when some automasking options are activated.
Summary

Crash triggers due to accessing member variables of brush.
Which value was passed as null to SCULPT_automasking_cache_init in
invoke function of every filter brush.

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Nov 22 2022, 8:00 PM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) added reviewers: Joseph Eagar (joeedh), Julien Kaspar (JulienKaspar).
Pratik Borhade (PratikPB2123) added a project: Sculpt, Paint & Texture.

@Joseph Eagar (joeedh) hi, feel free to commit alternative if fix is incorrect :)

Pratik Borhade (PratikPB2123) added a task: T102436: Crash using any Filter when some automasking options are activated..Nov 23 2022, 4:20 AM
Julien Kaspar (JulienKaspar) added a comment.Nov 24 2022, 2:19 PM

I can still reproduce crashes when using view normal auto-masking with occlusion enabled.
But the cavity curve crashes seem to be fixed here.

Joseph Eagar (joeedh) added a comment.Nov 24 2022, 5:53 PM

I'm going to fix this a bit differently; the brush is supposed to be able to be NULL in this case.

Pratik Borhade (PratikPB2123) abandoned this revision.Nov 24 2022, 5:59 PM

Sure, no problem. I'll close the patch in that case. Thanks for checking :)

Pratik Borhade (PratikPB2123) mentioned this in T102745: Sculpt Mode: Inconsistent cavity auto-masking results.Nov 25 2022, 4:12 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
3 lines
3 lines
3 lines

Diff 57920

View Options

source/blender/editors/sculpt_paint/sculpt_cloth.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_color.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_mesh.c

Loading...