Page MenuHome
Differential D16587

Cleanup: Remove the now dead IMB tile cache
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Nov 23 2022, 2:42 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB38573d515e49: Cleanup: Remove unused IMB tile cache code
Summary

This removes the dead code for the IBM tile cache APIs. These have been
unused for as far back as I could manage to search[1].

While investigating moving TIFF to OIIO as part of T101413, I found that
the imb_loadtiletiff call was orphaned and thought it best to clean it
up before moving forward.

The cache was introduced here for 2.53: https://developer.blender.org/rB008863daec1249d1f17bc69e1105e336db690d63
But I can't find the point where it was actually used in master? Perhaps it was only used for one of the open-movie branches at the time?

Diff Detail

Repository
rB Blender
Branch
oiio-remove-tifftiles (branched from master)
Build Status
Buildable 24793
Build 24793: arc lint + arc unit

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Nov 23 2022, 2:42 AM
Jesse Yurkovich (deadpin) created this revision.
Harbormaster completed remote builds in B24793: Diff 57939.Nov 23 2022, 2:43 AM
Jesse Yurkovich (deadpin) edited the summary of this revision. (Show Details)Nov 23 2022, 7:32 AM
Jesse Yurkovich (deadpin) added a reviewer: Brecht Van Lommel (brecht).
Jesse Yurkovich (deadpin) added a project: Images & Movies.
Brecht Van Lommel (brecht) accepted this revision.Nov 23 2022, 1:20 PM
This revision is now accepted and ready to land.Nov 23 2022, 1:20 PM
Closed by commit rB38573d515e49: Cleanup: Remove unused IMB tile cache code (authored by Jesse Yurkovich (deadpin)). · Explain WhyNov 24 2022, 5:14 AM
This revision was automatically updated to reflect the committed changes.
Jesse Yurkovich (deadpin) added a commit: rB38573d515e49: Cleanup: Remove unused IMB tile cache code.

Revision Contents
Changeset List

PathSize
source/
blender/
imbuf/
1 line
14 lines
8 lines
intern/
17 lines
45 lines
16 lines
2 lines
59 lines
98 lines

Diff 57939

View Options

source/blender/imbuf/CMakeLists.txt

Loading...
View Options

source/blender/imbuf/IMB_imbuf.h

Loading...
View Options

source/blender/imbuf/IMB_imbuf_types.h

Loading...
View Options

source/blender/imbuf/intern/IMB_filetype.h

Loading...
View Options

source/blender/imbuf/intern/allocimbuf.c

Loading...
View Options

source/blender/imbuf/intern/cache.c

Loading...
View Options

source/blender/imbuf/intern/filetype.c

Loading...
View Options

source/blender/imbuf/intern/module.c

Loading...
View Options

source/blender/imbuf/intern/readimage.c

Loading...
View Options

source/blender/imbuf/intern/tiff.c

Loading...