Page MenuHome
Differential D16591

Fix T102650: Wrong cursor in greasepencil fill operation
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 23 2022, 2:06 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Maniphest Tasks
T102650: Regression: Cursor arrow shows up after fill operation execution
Commits
rBb0810f788c9e: Fix T102650: Wrong cursor in greasepencil fill operation
Summary

Caused by rBbf8507414889: GPencil: New Fill Extend lines adjust with MMB

Above comit set the wrong cursors (WM_CURSOR_DEFAULT).
When releasing MMB, we need to return to WM_CURSOR_PAINT_BRUSH.
When exiting, we need to return to WM_CURSOR_DOT (since this is the
default cursor for the tool, see _defs_gpencil_paint >
generate_from_brushes)

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 23 2022, 2:06 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B24799: Diff 57957.Nov 23 2022, 2:07 PM
Philipp Oeser (lichtwerk) added projects: Grease Pencil, User Interface.Nov 23 2022, 2:07 PM
Antonio Vazquez (antoniov) accepted this revision.Nov 23 2022, 4:06 PM

Ok, I see what you meant, this make things more consistent.

This revision is now accepted and ready to land.Nov 23 2022, 4:06 PM
Closed by commit rBb0810f788c9e: Fix T102650: Wrong cursor in greasepencil fill operation (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 27 2022, 12:40 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBb0810f788c9e: Fix T102650: Wrong cursor in greasepencil fill operation.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
4 lines

Diff 58079

View Options

source/blender/editors/gpencil/gpencil_fill.c

Loading...