Page MenuHome
Differential D16606

Fix T102663: Meta strips from older versions are broken
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 24 2022, 7:34 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T102663: Regression: Meta strips from older versions are broken
Commits
rB7a4b3d2287b6: Fix T102663: Meta strips from older versions are broken
rB5a504a0d9ddd: Fix T102663: Meta strips from older versions are broken
Summary

Meta strip range was adjusted in versioning because of previous issues
by function version_fix_seq_meta_range. After speed_factor property
was added, this changed how function works and result was incorrect
function due to uninitialized property value.

Running version_fix_seq_meta_range after seq_speed_factor_set fixes
this issue.

Diff Detail

Repository
rB Blender
Branch
T102663 (branched from master)
Build Status
Buildable 24816
Build 24816: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 24 2022, 7:34 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B24815: Diff 57997.Nov 24 2022, 7:34 PM
Richard Antalik (ISS) updated this revision to Diff 57998.Nov 24 2022, 7:38 PM

Cleanup unintended change

Harbormaster completed remote builds in B24816: Diff 57998.Nov 24 2022, 7:38 PM
Sergey Sharybin (sergey) accepted this revision.Nov 25 2022, 10:39 AM

From the code side seems fine.

This revision is now accepted and ready to land.Nov 25 2022, 10:39 AM
Closed by commit rB5a504a0d9ddd: Fix T102663: Meta strips from older versions are broken (authored by Richard Antalik (ISS)). · Explain WhyNov 27 2022, 9:42 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB5a504a0d9ddd: Fix T102663: Meta strips from older versions are broken.
Philipp Oeser (lichtwerk) added a commit: rB7a4b3d2287b6: Fix T102663: Meta strips from older versions are broken.Jan 12 2023, 3:32 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
30 lines

Diff 57998

View Options

source/blender/blenloader/intern/versioning_300.cc

Loading...