Page MenuHome

Fix T102751: Missing updates to input sockets of muted nodes
AbandonedPublic

Authored by Michael Fraser (MichaelFraser) on Nov 25 2022, 11:55 PM.

Details

Summary

Fix T102751: Missing updates to input sockets of muted nodes

The input sockets of muted nodes still require updates in case an
incoming link is changed, e.g. a link is cut.

Diff Detail

Repository
rB Blender
Branch
Fix_T102751 (branched from master)
Build Status
Buildable 24831
Build 24831: arc lint + arc unit

Event Timeline

Michael Fraser (MichaelFraser) requested review of this revision.Nov 25 2022, 11:55 PM
Michael Fraser (MichaelFraser) created this revision.

Thanks for looking into this. While this fix does work, it's unfortunately not correct. The issue was that a few lines above socket.internal_link_input() returned null even when it should not. I committed the fix in rBb43bdd8ba28c: Fix T102751: missing tree update with muted nodes.

I see how you fixed it. Nice catch!