Fix T98951: Shadow catcher objects are double-counting data passes
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Nov 27 2022, 2:44 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB347c82be6dba: Fix T98951: Shadow catcher objects are double-counting data passes

Summary

Quite straightforward, but I'm submitting for review since it's BCon3.

Technically we could put this behind #ifdef __SHADOW_CATCHER__, but I doubt it's worth it for a single bit flag check.

Diff Detail

Repository

rB Blender

Branch

fix-T98951 (branched from master)

Build Status

Buildable 24836
Build 24836: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) requested review of this revision.Nov 27 2022, 2:44 AM

Lukas Stockner (lukasstockner97) created this revision.

Harbormaster completed remote builds in B24836: Diff 58071.Nov 27 2022, 2:44 AM

Brecht Van Lommel (brecht) accepted this revision.Nov 28 2022, 6:00 PM

This revision is now accepted and ready to land.Nov 28 2022, 6:00 PM

Closed by commit rB347c82be6dba: Fix T98951: Shadow catcher objects are double-counting data passes (authored by Lukas Stockner (lukasstockner97)). · Explain WhyDec 17 2022, 1:45 AM

This revision was automatically updated to reflect the committed changes.

Lukas Stockner (lukasstockner97) added a commit: rB347c82be6dba: Fix T98951: Shadow catcher objects are double-counting data passes.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

film/

data_passes.h

6 lines

denoising_passes.h

9 lines

Diff 58071

View Options

intern/cycles/kernel/film/data_passes.h