Page MenuHome

Geometry Node: Change output socket name to Instances: Consistent tooltips
ClosedPublic

Authored by Iliya Katueshenock (Moder) on Nov 27 2022, 8:48 PM.

Details

Diff Detail

Repository
rB Blender

Event Timeline

source/blender/makesrna/intern/rna_nodetree.c
10018–10021

I would keep this one, but the other changes aren't necessarily an improvement IMO.

It's helpful to use a different wording in tooltips compared to UI text, that way they don't just say the same thing.

In the end, the purpose of the node is to retrieve geometry from a collection. It just happens to use instances as a format

source/blender/makesrna/intern/rna_nodetree.c
10018–10021

wanted to clarify that the transformations will be applied to instances. But if you think about it, it probably doesn’t matter to the user whether the instances are transformed, or the geometry in them?

source/blender/makesrna/intern/rna_nodetree.c
10018–10021

Yes, I see your point. I think it's relevant for most advanced uses.
Mainly I just don't want all of the "geometry" words in the tooltips to be replaced with "instances" since "geometry" is a more beginner-friendly word IMO.
But updating for improved correctness and detail could still make sense

I will try to recompose the expressions so that it would be reported about the geometry, and that the resulting instances are transformed.

Without redoing all the sentences too much, it turned out something like this

Hans Goudey (HooglyBoogly) added inline comments.
source/blender/makesrna/intern/rna_nodetree.c
10021

Internal geometry don't -> The internal geometry doesn't

This revision is now accepted and ready to land.Dec 5 2022, 4:08 PM
Iliya Katueshenock (Moder) marked an inline comment as done.
source/blender/makesrna/intern/rna_nodetree.c
10004–10011

I left out these two changes, since they made this text a bit more complicated, and I don't think that's necessary.

I also tweaked the description below to clarify it a bit

Iliya Katueshenock (Moder) marked an inline comment as done.Dec 9 2022, 11:07 PM