Page MenuHome
Differential D16643

Fix T101130: Regression: Scaling of NLA Strip Via S Hotkey Not Working
ClosedPublic
Actions

Authored by Nate Rupsis (nrupsis) on Nov 29 2022, 5:16 PM.

Details

Reviewers
Brad Clark (RiggingDojo)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T101130: Regression: Scaling of NLA Strip Via S Hotkey Not Working
Commits
rB51759e659579: Fix T101130: Scaling of NLA Strip Via S Hotkey Not Working
Summary

The scaling code still assumed that adjusting the start & end frames would change the playback scale of strips.
This is now solved by recomputing the strip scale based on the other properties.

The scaling behaviour (everything is scaled as a group, relative to the playhead position) remains the same as before.

Pair-programmed with @Nate Rupsis (nrupsis).

This is for Blender 3.4 for sure, and probably also will get back-ported to 3.3-LTS.

Test builds are available at https://builder.blender.org/download/patch/D16643/

Diff Detail

Repository
rB Blender
Branch
blender-v3.4-release
Build Status
Buildable 24857
Build 24857: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Nov 29 2022, 5:16 PM
Sybren A. Stüvel (sybren) created this revision.
Harbormaster completed remote builds in B24857: Diff 58151.Nov 29 2022, 5:16 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 58153.Nov 29 2022, 5:21 PM
  • Reset scale after cancelling transform
Harbormaster completed remote builds in B24858: Diff 58153.Nov 29 2022, 5:21 PM
Sybren A. Stüvel (sybren) added a task: T101130: Regression: Scaling of NLA Strip Via S Hotkey Not Working.Nov 29 2022, 5:33 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
Sybren A. Stüvel (sybren) added projects: Animation & Rigging, BF Blender (3.4).
Nate Rupsis (nrupsis) awarded a token.Nov 29 2022, 9:41 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Dec 2 2022, 12:13 PM
Sybren A. Stüvel (sybren) edited projects, added BF Blender (3.5); removed BF Blender (3.4).Dec 5 2022, 3:32 PM

Too late to get this into Blender 3.4.

Nate Rupsis (nrupsis) commandeered this revision.Dec 13 2022, 3:19 PM
Nate Rupsis (nrupsis) added a reviewer: Sybren A. Stüvel (sybren).
Nate Rupsis (nrupsis) updated this revision to Diff 58555.Dec 13 2022, 3:20 PM

Adding in TFM_TIME_EXTEND option to NLA strip transform update

Harbormaster completed remote builds in B25019: Diff 58555.Dec 13 2022, 3:20 PM
Sybren A. Stüvel (sybren) accepted this revision.Dec 13 2022, 3:45 PM

LGTM!

This revision is now accepted and ready to land.Dec 13 2022, 3:45 PM
Nate Rupsis (nrupsis) closed this revision.Dec 15 2022, 4:54 PM

Resolved by rB51759e659579eb48181306ae1574d4dfdd4a4ed9

Forgot to add the Dxxxx reference to the commit :(

Sybren A. Stüvel (sybren) added a commit: rB51759e659579: Fix T101130: Scaling of NLA Strip Via S Hotkey Not Working.Dec 16 2022, 10:50 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
20 lines
editors/
transform/
24 lines

Diff 58151

View Options

source/blender/blenkernel/intern/nla.c

Loading...
View Options

source/blender/editors/transform/transform_convert_nla.c

Loading...