Geometry Node: Input Image node.
T102854: Input Image node
Details
Diff Detail
Event Timeline
I've had some thoughts so far about what the naming should be for this node.
The problem is that when looking at other nodes for the drag drop, I chose GEO_NODE_IMAGE. But now, questioning this function, as well as paying attention to the nodes from other editors, I see some strangeness.
| Geometry | Shader | Texture | Compositor | |
|---|---|---|---|---|
| Name: | Image Texture | Image Texture | Image | Image |
| Identifier: | GEO_NODE_IMAGE | SH_NODE_TEX_IMAGE | TEX_NODE_IMAGE | CMP_NODE_IMAGE |
The names do not reflect the direct functionality of the nodes. It depends on the editor and its specifics. It may be convenient in isolation, but as I understand it, everything is moving towards unification and the possibility of transferring trees between different editors. And just to leave room for adding an image input node to shaders and textures in the future...
I really don't want to start a big patch to change other nodes to get consensus. But, if it may be in the future, I would like to be careful about how the node should be called now.
I see the division of these nodes into such groups of functions:
- Image input.
- Sampling the image (not sure about the mention of texture, but also maybe image texture)
- Other operations, more specific and for editor, even in the future, are unlikely to be transferred between editors.
| Input Image | Image Texture / Sample Image | |
|---|---|---|
| Geometry | GEO_NODE_IMAGE | GEO_NODE_IMAGE_TEX |
| Shader | SH_NODE_IMAGE | SH_NODE_IMAGE_TEX |
| Texture | TEX_NODE_IMAGE | TEX_NODE_IMAGE_TEX |
| Compositor | CMP_NODE_IMAGE | CMP_NODE_IMAGE_TEX |
And matching names...
But since some names are already taken now, and so far it is not planned to change them, so as not to create confusion and leave the possibility of simplifying everything in the future, you can consider
GEO_NODE_INPUT_IMAGE and Image name for interface (but input_image for api)
Maybe the same thoughts on development in the future have @Brecht Van Lommel (brecht) @Omar Emara (OmarSquircleArt)
I think names Image and Image Texture are fine. It can be named that way for geometry nodes, and then other nodes can follow later.
| source/blender/nodes/geometry/nodes/node_geo_image.cc | ||
|---|---|---|
| 51 | Missing newline | |





