Page MenuHome

Geometry Node: Input Image node
ClosedPublic

Authored by Iliya Katueshenock (Moder) on Nov 29 2022, 5:38 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)
  • The names are more in line with image input nodes from other editors.
Iliya Katueshenock (Moder) set the repository for this revision to rB Blender.Nov 29 2022, 6:19 PM

I've had some thoughts so far about what the naming should be for this node.

The problem is that when looking at other nodes for the drag drop, I chose GEO_NODE_IMAGE. But now, questioning this function, as well as paying attention to the nodes from other editors, I see some strangeness.

GeometryShaderTextureCompositor
Name:Image TextureImage TextureImageImage
Identifier:GEO_NODE_IMAGESH_NODE_TEX_IMAGETEX_NODE_IMAGECMP_NODE_IMAGE

The names do not reflect the direct functionality of the nodes. It depends on the editor and its specifics. It may be convenient in isolation, but as I understand it, everything is moving towards unification and the possibility of transferring trees between different editors. And just to leave room for adding an image input node to shaders and textures in the future...

I really don't want to start a big patch to change other nodes to get consensus. But, if it may be in the future, I would like to be careful about how the node should be called now.

I see the division of these nodes into such groups of functions:

  • Image input.
  • Sampling the image (not sure about the mention of texture, but also maybe image texture)
  • Other operations, more specific and for editor, even in the future, are unlikely to be transferred between editors.
Input ImageImage Texture / Sample Image
GeometryGEO_NODE_IMAGEGEO_NODE_IMAGE_TEX
ShaderSH_NODE_IMAGESH_NODE_IMAGE_TEX
TextureTEX_NODE_IMAGETEX_NODE_IMAGE_TEX
CompositorCMP_NODE_IMAGECMP_NODE_IMAGE_TEX

And matching names...

But since some names are already taken now, and so far it is not planned to change them, so as not to create confusion and leave the possibility of simplifying everything in the future, you can consider

GEO_NODE_INPUT_IMAGE and Image name for interface (but input_image for api)

Maybe the same thoughts on development in the future have @Brecht Van Lommel (brecht) @Omar Emara (OmarSquircleArt)

I think names Image and Image Texture are fine. It can be named that way for geometry nodes, and then other nodes can follow later.

source/blender/nodes/geometry/nodes/node_geo_image.cc
4–15

Pretty sure some of these includes aren't needed

40

Use reinterpret_cast

Iliya Katueshenock (Moder) marked 2 inline comments as done.

This was forgotten after experimenting with the drag menu.

Hans Goudey (HooglyBoogly) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_image.cc
51

Missing newline

This revision is now accepted and ready to land.Dec 5 2022, 6:28 PM
Iliya Katueshenock (Moder) marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.