Fix T102893: Assert Opening File Browser (Win32)
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Dec 1 2022, 9:18 PM.

Details

Reviewers: None
Maniphest Tasks: T102893: Assert on opening the file browser
Commits: rB4c1b250e172a: Fix T102893: Assert Opening File Browser (Win32)

Summary

Fix debug assert opening File Browser on Windows platform.

Opening File Browser in Windows, relbase is initially "//" which does not pass debug assert in current_relpath_append that the last character be SEP character ("\" on Windows).

This patch just alters this assert to allow either SEP or ALTSEP, which will pass on all platforms.

Will commit without further review - approved by Julian to do so.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Dec 1 2022, 9:18 PM

Harley Acheson (harley) created this revision.

Harley Acheson (harley) added a task: T102893: Assert on opening the file browser.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 1 2022, 9:27 PM

Closed by commit rB4c1b250e172a: Fix T102893: Assert Opening File Browser (Win32) (authored by Harley Acheson (harley)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rB4c1b250e172a: Fix T102893: Assert Opening File Browser (Win32).

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_file/

filelist.cc

2 lines

Diff 58233

View Options

source/blender/editors/space_file/filelist.cc

Fix T102893: Assert Opening File Browser (Win32)ClosedPublicActions