Cleanup: Use topology cache of group output node
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Dec 5 2022, 11:49 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Commits

rBfc5f7a1e2d5e: Cleanup: Use topology cache of group output node

Summary

Using a cache greatly simplifies access to the output node.
I touched on the most common and understandable cases for me.
The texture nodes were touched because it looked pretty generic.

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Dec 5 2022, 11:49 PM

Iliya Katueshenock (Moder) created this revision.

Also shader and texture common functions

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)Dec 6 2022, 12:40 AM

Iliya Katueshenock (Moder) set the repository for this revision to rB Blender.

Iliya Katueshenock (Moder) added a project: Nodes & Physics.

Iliya Katueshenock (Moder) added a reviewer: Brecht Van Lommel (brecht).Dec 6 2022, 12:42 AM

Generally I'm not sure it's worth doing any cleanup in texture nodes at all, since the aim is to completely replace it somewhat soon. But the improvement looks nice here for shader nodes anyway. I think that's only used for viewport & EEVEE stuff though.

Hans Goudey (HooglyBoogly) accepted this revision.Dec 6 2022, 1:15 AM

This revision is now accepted and ready to land.Dec 6 2022, 1:15 AM

It wasn't hard for me to change it now, so I just didn't see much reason not to do it.

If this code changes according to the new nodes, it will be good if the new way of accessing the output node is also used.

Closed by commit rBfc5f7a1e2d5e: Cleanup: Use topology cache of group output node (authored by Iliya Katueshenock (Moder), committed by Hans Goudey (HooglyBoogly)). · Explain WhyDec 9 2022, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBfc5f7a1e2d5e: Cleanup: Use topology cache of group output node.