Page MenuHome

Mesh Bisect: add header info message for modal operation
ClosedPublic

Authored by Simon Repp (simonrepp) on Jan 2 2014, 11:30 AM.

Diff Detail

Event Timeline

Looks good to me from a user perspective.

Brecht Van Lommel (brecht) requested changes to this revision.Jan 2 2014, 5:43 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/mesh/editmesh_bisect.c
117

This is not necessary, you can use sizeof(header) for BLI_snprintf.

158

Actually you don't need BLI_snprintf at all, you can pass IFACE_("LMB: Click and drag to draw cut line") directly to ED_area_headerprint or assign it to a const char*, no need to do printf when it's a plain string.

191

Code style convention is

}
else {
Simon Repp (simonrepp) updated this revision to Unknown Object (????).Jan 2 2014, 6:41 PM

I'm baffled how i could fail on such a no-brainer, i'll take extra care before submitting my next patch, sorry ... :(