Fix T102914: bpy.ops.wm.append no longer supports / in paths for WIN32
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Dec 6 2022, 1:06 AM.

Details

Reviewers

Julian Eisel (Severin)
Harley Acheson (harley)

Maniphest Tasks

T102914: Regression: bpy.ops.wm.append can't run correct in blender 3.4

Commits

rBa16ef95ff6ce: Fix T102914: bpy.ops.wm.append no longer supports / in paths for WIN32

Summary

Support both forward and back slashes on WIN32.

Forward slashes for paths in WIN32 was removed in [0] (for BLI_path_join)
& [1] (for BLI_path_name_at_index), this is correct on UNIX as back
slashes can be used in paths but not on WIN32 which can use both.

Note that other path functions such as BLI_path_append &
BLI_path_slash_ensure should be updated too, but this is out of scope
for a bug-fix.

Documenting and ensuring Windows path handling functions all handle
forward slashes can be done separately.

[0]: 8f7ab1bf46d5e8610b167180b7631ff62e718a08
[1]: 511ae2226473df57e47b439392da387cd355abef

NOTE: This is a follow up patch that completes support for slashes in both directions on WIN32: P3364.

Diff Detail

Repository: rB Blender

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Dec 6 2022, 1:06 AM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B24939: Diff 58331.Dec 6 2022, 1:06 AM

Campbell Barton (campbellbarton) retitled this revision from Cleanup: remove unused argument to Fix T102914: bpy.ops.wm.append no longer supports / in paths for WIN32.Dec 6 2022, 1:06 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Another commit was included accidentally.

Harbormaster completed remote builds in B24940: Diff 58332.Dec 6 2022, 1:09 AM

Attempt to remove additional commit (take 2)

Harbormaster completed remote builds in B24941: Diff 58333.Dec 6 2022, 1:14 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Dec 6 2022, 1:23 AM

Campbell Barton (campbellbarton) added a reviewer: Julian Eisel (Severin).

Campbell Barton (campbellbarton) added a reviewer: Harley Acheson (harley).Dec 6 2022, 1:25 AM

Campbell Barton (campbellbarton) mentioned this in rB8f7ab1bf46d5: BLI_path: only operate on native path slashes for BLI_path_join.Dec 6 2022, 1:32 AM

This fixes the issue reported in T102914: Regression: bpy.ops.wm.append can't run correct in blender 3.4 in that I can successfully append (on Windows) using either of

bpy.ops.wm.append(filepath='D:\\Test\\Simple.blend\\Object\\Cube', filename='Cube',directory='D:\\Test\\Simple.blend\\Object\\')
bpy.ops.wm.append(filepath='D:/Test/Simple.blend/Object/Cube', filename='Cube',directory='D:/Test/Simple.blend/Object/')

This revision is now accepted and ready to land.Dec 6 2022, 2:16 AM

Closed by commit rBa16ef95ff6ce: Fix T102914: bpy.ops.wm.append no longer supports / in paths for WIN32 (authored by Campbell Barton (campbellbarton)). · Explain WhyDec 6 2022, 3:13 AM

This revision was automatically updated to reflect the committed changes.

Campbell Barton (campbellbarton) added a commit: rBa16ef95ff6ce: Fix T102914: bpy.ops.wm.append no longer supports / in paths for WIN32.