Differential D16704

Fix T102966: Curves editmode selection drawing not stable / flickering
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 6 2022, 2:02 PM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Hans Goudey (HooglyBoogly)

Maniphest Tasks

T102966: Curves editmode: selection drawing not stable / flickering

Commits

rBcc1ba74ce2f2: Fix T102966: Curves editmode selection drawing not stable / flickering

Summary

Issue was the lifetime of GPUVertFormat & GPUVertAttr.
Both need to be static in the function to be persistent here (and
handled appropriately).

Was an error in rB319ee296fd0c.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 6 2022, 2:02 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B24949: Diff 58350.Dec 6 2022, 2:02 PM

Philipp Oeser (lichtwerk) added projects: EEVEE & Viewport, Nodes & Physics, Geometry Nodes.Dec 6 2022, 2:03 PM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Dec 6 2022, 2:06 PM

Good to know! Didn't realize this needed to be static.

This revision is now accepted and ready to land.Dec 6 2022, 2:40 PM

Philipp Oeser (lichtwerk) mentioned this in D16281: Curves editmode: edit points are drawn from evaluated curves.Dec 6 2022, 4:57 PM

Clément Foucault (fclem) accepted this revision.Dec 7 2022, 9:04 AM

Closed by commit rBcc1ba74ce2f2: Fix T102966: Curves editmode selection drawing not stable / flickering (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 7 2022, 9:43 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBcc1ba74ce2f2: Fix T102966: Curves editmode selection drawing not stable / flickering.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_impl_curves.cc

6 lines

Diff 58375

source/blender/draw/intern/draw_cache_impl_curves.cc

Loading...