I see the same fix is in master, but I'm not sure it's correct? This seems like vertices from the last hit triangle will always be made active, even if another triangle was hit before.

Instead it could track some bool active_vertex_initialized to determine if it's the first time?

This revision now requires changes to proceed.Dec 6 2022, 4:27 PM

Actually I think I was wrong, the active vertex is meant to be on the same triangle that was hit?

Will go ahead and commit this since we want to move to bcon5 and fixing the crash is the most important part of this.

This revision is now accepted and ready to land.Dec 6 2022, 6:02 PM

Closed by commit rB31ccf79011bd: Fix T102336: dynamic topology crash (authored by Joseph Eagar (joeedh), committed by Brecht Van Lommel (brecht)). · Explain WhyDec 6 2022, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB31ccf79011bd: Fix T102336: dynamic topology crash.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

pbvh_bmesh.c

8 lines

Diff 58365

View Options

source/blender/blenkernel/intern/pbvh_bmesh.c

Fix T102336: Dynamic Topology Crash ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 58365

source/blender/blenkernel/intern/pbvh_bmesh.c

Fix T102336: Dynamic Topology Crash
ClosedPublic
Actions

Revision Contents
Changeset List