Page MenuHome

Use absolute values to support negative strength lights in light tree
ClosedPublic

Authored by Alaska (Alaska) on Dec 8 2022, 5:24 AM.

Details

Summary

Cycles supports lights with "negative strength". However the light tree
didn't properly handle these lights. And under certain circumstances there
could be large increases in noise.

For example, in the scene I have attached below there are two lights
configured to be opposites of each other. The combined energy of these
lights in master is 1000 - 1000, which means the node these lights
occupy in the light tree has "zero energy" and the direct sampling
of these lights are skipped, which results in a large increase in noise.

MasterThis Patch

Diff Detail

Repository
rB Blender
Branch
use_absolute_energy (branched from master)
Build Status
Buildable 24970
Build 24970: arc lint + arc unit

Event Timeline

Alaska (Alaska) requested review of this revision.Dec 8 2022, 5:24 AM
Alaska (Alaska) created this revision.
Alaska (Alaska) edited the summary of this revision. (Show Details)Dec 8 2022, 5:25 AM
Alaska (Alaska) edited the summary of this revision. (Show Details)Dec 8 2022, 10:36 AM
This revision is now accepted and ready to land.Dec 12 2022, 5:19 PM