Page MenuHome

Tests: test availability of new bundled Python libraries
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Dec 9 2022, 10:51 PM.

Details

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 24984
Build 24984: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Dec 9 2022, 10:51 PM
Brecht Van Lommel (brecht) created this revision.

This can land when all the platforms have been updated with new libraries, but can be useful for platform maintainer testing now.

Thanks! that was useful! While this will work for us, down stream builders may want to have these separated out depending if support for a dep was enabled or not? that being said, we could just land it as is and see if any one complains.

Brecht Van Lommel (brecht) retitled this revision from Tests: test availability of new bundles Python libraries to Tests: test availability of new bundled Python libraries.Dec 12 2022, 4:53 PM
Ray Molenkamp (LazyDodo) requested changes to this revision.Dec 16 2022, 4:28 PM

script_python_bundled_modules fails on windows since TEST_PYTHON_EXE is pointing to K:/BlenderGit/blender/../lib/win64_vc15/python/310/bin/python$<$<CONFIG:Debug>:_d>.exe which is a stock install of python, the extra modules are installed on demand in creators install, likely just needs to be pointed to the one in the bin folder but i need to check if that breaks anything else.

@Brecht Van Lommel (brecht) just requesting changes so it doesn't land while i sort this out, no action required on your end for now

This revision now requires changes to proceed.Dec 16 2022, 4:28 PM

Test Python executable from inside Blender, to avoid requiring CMake changes.

Works fine on all platforms now.
https://builder.blender.org/admin/#/builders/136/builds/342

More reliable this way since TEST_PYTHON_EXE is a CMake option so it could point to another Python executable even on Linux/macOS.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2023, 2:16 PM
This revision was automatically updated to reflect the committed changes.