Page MenuHome
Differential D16741

Cleanup: Various Cycles code
ClosedPublic
Actions

Authored by Thomas Dinges (dingto) on Dec 10 2022, 5:19 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB54aec4629ecd: Cleanup: Remove unused code in Cycles
Summary
  • preempt_attr was copied from CUDA, but not used in HIP.
  • Remove shadowed variable before conditional.

Diff Detail

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Dec 10 2022, 5:19 PM
Thomas Dinges (dingto) created this revision.
Brecht Van Lommel (brecht) requested changes to this revision.Dec 12 2022, 5:18 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/scene/image.cpp
362

This is not redundant, it's a double checked lock.

This revision now requires changes to proceed.Dec 12 2022, 5:18 PM
Thomas Dinges (dingto) updated this revision to Diff 58517.Dec 12 2022, 5:21 PM
Thomas Dinges (dingto) marked an inline comment as done.
Thomas Dinges (dingto) edited the summary of this revision. (Show Details)

Revert changes in image.cpp.

Brecht Van Lommel (brecht) accepted this revision.Dec 12 2022, 5:22 PM
This revision is now accepted and ready to land.Dec 12 2022, 5:22 PM
Closed by commit rB54aec4629ecd: Cleanup: Remove unused code in Cycles (authored by Thomas Dinges (dingto)). · Explain WhyDec 12 2022, 6:18 PM
This revision was automatically updated to reflect the committed changes.
Thomas Dinges (dingto) added a commit: rB54aec4629ecd: Cleanup: Remove unused code in Cycles.

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
hip/
4 lines
scene/
3 lines
1 line

Diff 58481

View Options

intern/cycles/device/hip/device.cpp

Loading...
View Options

intern/cycles/scene/image.cpp

Loading...
View Options

intern/cycles/scene/light.cpp

Loading...