Cleanup: Various Cycles code
ClosedPublic
Actions

Authored by Thomas Dinges (dingto) on Dec 10 2022, 5:19 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB54aec4629ecd: Cleanup: Remove unused code in Cycles

Summary

preempt_attr was copied from CUDA, but not used in HIP.
Remove shadowed variable before conditional.

Diff Detail

Repository: rB Blender

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Dec 10 2022, 5:19 PM

Thomas Dinges (dingto) created this revision.

Brecht Van Lommel (brecht) requested changes to this revision.Dec 12 2022, 5:18 PM

Brecht Van Lommel (brecht) added inline comments.

intern/cycles/scene/image.cpp
362 ↗	(On Diff #58481)	This is not redundant, it's a double checked lock.

This revision now requires changes to proceed.Dec 12 2022, 5:18 PM

Revert changes in image.cpp.

Brecht Van Lommel (brecht) accepted this revision.Dec 12 2022, 5:22 PM

This revision is now accepted and ready to land.Dec 12 2022, 5:22 PM

Closed by commit rB54aec4629ecd: Cleanup: Remove unused code in Cycles (authored by Thomas Dinges (dingto)). · Explain WhyDec 12 2022, 6:18 PM

This revision was automatically updated to reflect the committed changes.

Thomas Dinges (dingto) added a commit: rB54aec4629ecd: Cleanup: Remove unused code in Cycles.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

hip/

device.cpp

4 lines

scene/

light.cpp

1 line

Diff 58518

View Options

intern/cycles/device/hip/device.cpp