Page MenuHome
Differential D16761

WIP: Small refactor of some of the RNA diffing API.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Dec 13 2022, 1:30 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Julian Eisel (Severin)
Commits
rBfcddb7cda766: Small refactor of some of the RNA diffing API.
Summary

Propagate eRNAOverrideMatchResult 'return' flags at higher level into
BKE API, instead of just returning a boolean true when new override
rules have been created.

NOTE: This is an intermediary step towards fixing T102766.

Diff Detail

Repository
rB Blender
Branch
tmp-liboverride-refactor (branched from master)
Build Status
Buildable 25043
Build 25043: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Dec 13 2022, 1:30 PM
Bastien Montagne (mont29) created this revision.
Harbormaster completed remote builds in B25015: Diff 58551.Dec 13 2022, 1:30 PM
Brecht Van Lommel (brecht) added a comment.Dec 14 2022, 8:02 PM

In C++ it's possible to forward declare enums when specifying the data type, like enum eRNAOverrideMatchResult : unsigned int.

However in C the only solution is to just use int or to add includes in headers to define the enum.

Bastien Montagne (mont29) updated this revision to Diff 58638.Dec 15 2022, 7:23 AM

Updating, fixing weird memory corruptions by enforcing int type for the enum.

Harbormaster completed remote builds in B25043: Diff 58638.Dec 15 2022, 7:23 AM
Bastien Montagne (mont29) added a comment.Dec 15 2022, 7:24 AM

Thanks @Brecht Van Lommel (brecht), just wanted to be sure I was not missing anything here.

Patch is now ready, not sure if you guys want/need to review it though.

Bastien Montagne (mont29) edited the summary of this revision. (Show Details)Dec 15 2022, 7:24 AM
Bastien Montagne (mont29) updated this revision to Diff 58788.Dec 21 2022, 6:08 AM
Bastien Montagne (mont29) edited the summary of this revision. (Show Details)

Rebase on master and minor cleanup before commit.

Harbormaster completed remote builds in B25114: Diff 58788.Dec 21 2022, 6:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 21 2022, 7:03 AM
Closed by commit rBfcddb7cda766: Small refactor of some of the RNA diffing API. (authored by Bastien Montagne (mont29)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rBfcddb7cda766: Small refactor of some of the RNA diffing API..

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
12 lines
intern/
2 lines
4 lines
49 lines
6 lines
makesrna/
11 lines
intern/
2 lines
windowmanager/
intern/
2 lines

Diff 58638

View Options

source/blender/blenkernel/BKE_lib_override.h

Loading...
View Options

source/blender/blenkernel/intern/blendfile.c

Loading...
View Options

source/blender/blenkernel/intern/blendfile_link_append.c

Loading...
View Options

source/blender/blenkernel/intern/lib_override.cc

Loading...
View Options

source/blender/blenkernel/intern/undo_system.c

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_ID.c

Loading...
View Options

source/blender/windowmanager/intern/wm_files.c

Loading...