Page MenuHome
Differential D16779

Paint Orbit around selection/stroke: remove redundant case
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 15 2022, 10:56 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T101766: Curves sculptmode: orbit around selection does not orbit around last stroke
Commits
rB0e1440eefd98: Paint: Orbit around selection/stroke: remove redundant case
Summary

Since rB8014180720d8, all paint modes support orbiting around last
stroke, so [a] the comment there is out of date and [b] the fallback
case of orbiting around the center wil never be used.

Spotted while looking into T101766.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 15 2022, 10:56 AM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B25045: Diff 58641.Dec 15 2022, 10:56 AM
Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, User Interface.Dec 15 2022, 10:56 AM
Campbell Barton (campbellbarton) accepted this revision.Dec 15 2022, 11:19 AM

LGTM, if the last stroke information isn't available it falls back to the object center which seems fine.

This revision is now accepted and ready to land.Dec 15 2022, 11:19 AM
Campbell Barton (campbellbarton) added inline comments.Dec 15 2022, 11:19 AM
source/blender/editors/space_view3d/view3d_navigate.c
178

This could just pass in lastofs.

Closed by commit rB0e1440eefd98: Paint: Orbit around selection/stroke: remove redundant case (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 15 2022, 12:28 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB0e1440eefd98: Paint: Orbit around selection/stroke: remove redundant case.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
14 lines

Diff 58642

View Options

source/blender/editors/space_view3d/view3d_navigate.c

Loading...