Differential D16780
Fix T90732: crash when alt+LMB to change custom properties of different bones Authored by Christoph Lendenfeld (ChrisLend) on Dec 15 2022, 1:44 PM.
Details
The issue occured only on pose bones when ALT dragging a property that existed on the active bone but not on the selected. I also couldn't reproduce the issue with a Release build. Only in Debug it crashed. It seems the PropertyRNA was invalid while the PointerRNA was valid.
Diff Detail
Event TimelineComment Actions This is a tricky thing. Your patch indeed prevents the crash, but it also prevents updating multiple IDs that have the same property. You can see that with the attached file, where bones A and C have the custom property, but bone B does not. In master (with a release build so it doesn't crash), selecting all and alt-dragging the property will manipulate all bones that actually have this property. @Bastien Montagne (mont29) could you help a hand here?
Comment Actions Although reading the code of RNA_struct_contains_property I think you'll have to update it first to also check for ID properties... Comment Actions Hrmmpppf... things are actually more complicated... Issue is, when there is no path given, lprop is just assigned from prop, which is fine for regular RNA properties, but absolute nonsense for IDProperties. Think UI_context_copy_to_selected_check should check early for given prop being an IDProperty, and change how it handles non-path case then (since it cannot just assign prop to lprop then, but rather has to search for a matching new lprop in IDProperties from ptr_link. Can't see a better way to do so, than to create the path from ptr to prop (RNA_path_from_struct_to_idproperty) in that case, and then try to resolve that path on ptr_link, and return false in case it cannot be found. Having an assert that prop != lprop in case prop is an IDProperty is also probably a good idea. Comment Actions @Bastien Montagne (mont29) Sorry I need a bit more guidance on this, how do I get an IDProperty from a PropertyRNA? Comment Actions Checking if a RNA property is actually an IDProperty can be done with RNA_property_is_idprop. Don't think you actually need to get the IDProperty, everything should be doable through the RNA API as described in my previous comment? | ||||||||