Differential D16790

Build: always install all shared libraries regardless of build options
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Dec 16 2022, 2:04 PM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Ray Molenkamp (LazyDodo)

Summary

There are dependencies between shared libraries, and Python modules which are
always installed on Linux and macOS can use these also.

Instead of adding logic for dealing with dependencies and conditional Python module
installs, just always install everything when using precompiled libraries. This does not
affect compile time which would be the main reason to turn off build options, and it
does not affect the case where system libraries are used.

Diff Detail

Repository

Branch

master

Build Status

Buildable 25063
Build 25063: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.Dec 16 2022, 2:04 PM

Harbormaster completed remote builds in B25055: Diff 58671.Dec 16 2022, 2:04 PM

Fix merge error.

Harbormaster completed remote builds in B25056: Diff 58672.Dec 16 2022, 2:06 PM

Same for Windows.

Harbormaster completed remote builds in B25057: Diff 58673.Dec 16 2022, 2:19 PM

Fix

Harbormaster completed remote builds in B25058: Diff 58674.Dec 16 2022, 2:23 PM

Remove Linux only exception.

Harbormaster completed remote builds in B25060: Diff 58677.Dec 16 2022, 2:48 PM

Brecht Van Lommel (brecht) requested review of this revision.Dec 16 2022, 2:50 PM

Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)

Brecht Van Lommel (brecht) added reviewers: Campbell Barton (campbellbarton), Ray Molenkamp (LazyDodo).

Remove build option dependencies that are only link time.

Harbormaster completed remote builds in B25063: Diff 58681.Dec 16 2022, 3:34 PM

Brecht Van Lommel (brecht) added a child revision: D16733: Tests: test availability of new bundled Python libraries.Dec 16 2022, 3:42 PM

In principle I'd rather avoid this, but in practice properly handling library inter dependencies is reasonably involved.

This revision is now accepted and ready to land.Dec 17 2022, 1:58 AM

Campbell Barton (campbellbarton) added inline comments.Dec 17 2022, 1:58 AM

build_files/cmake/platform/platform_apple.cmake
364	picky - indentation.

Committed in rBeb7ac996cc2a: Build: install all shared libraries regardless of build options.

Brecht Van Lommel (brecht) closed this revision.Jan 4 2023, 11:25 AM

Revision Contents
Changeset List

Path

Size

24 lines

build_files/

cmake/

platform/

platform_apple.cmake

25 lines

platform_unix.cmake

51 lines

source/

creator/

431 lines

Diff 58681

CMakeLists.txt

Loading...

build_files/cmake/platform/platform_apple.cmake

Loading...

build_files/cmake/platform/platform_unix.cmake

Loading...

source/creator/CMakeLists.txt

Loading...