Page MenuHome
Differential D1679

BLI_path_util_test.cc - new tests
Needs ReviewPublic
Actions

Authored by Michał Ziobro (Muchomor) on Dec 19 2015, 5:43 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T41252: BLI_path_util_test.cc TODO's
Summary

I added a few tests for some functions from BLI_path_util.h

Diff Detail

Repository
rB Blender

Event Timeline

Michał Ziobro (Muchomor) updated this revision to Diff 5587.Dec 19 2015, 5:43 PM
Michał Ziobro (Muchomor) retitled this revision from to BLI_path_util_test.cc - new tests.
Michał Ziobro (Muchomor) updated this object.
Michał Ziobro (Muchomor) added a reviewer: Campbell Barton (campbellbarton).
Michał Ziobro (Muchomor) set the repository for this revision to rB Blender.
Michał Ziobro (Muchomor) added projects: BF Blender, Restricted Project.
Michał Ziobro (Muchomor) added a subscriber: Campbell Barton (campbellbarton).
Michał Ziobro (Muchomor) added a subscriber: Michał Ziobro (Muchomor).
Michał Ziobro (Muchomor) updated this revision to Diff 5588.Dec 19 2015, 9:02 PM
Michał Ziobro (Muchomor) updated this revision to Diff 5589.Dec 19 2015, 11:48 PM
Michał Ziobro (Muchomor) updated this revision to Diff 5590.
Sergey Sharybin (sergey) requested changes to this revision.Dec 22 2015, 3:44 PM
Sergey Sharybin (sergey) added a reviewer: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Tests are to be atomic, meaning they should not be just grouped by the function they're testing, but should also indicate what exact case they're testing.

PathUtilEnsureExtensionNoOrigFileExtension
PathUtilEnsureExtensionWothOrigFileExtension

and so on. otherwise you don't easily see what exact case fails.

This revision now requires changes to proceed.Dec 22 2015, 3:44 PM
Michał Ziobro (Muchomor) updated this revision to Diff 5622.Dec 22 2015, 10:02 PM
Michał Ziobro (Muchomor) edited edge metadata.

Hmm, I split new tests, should I do same with previous?

Sergey Sharybin (sergey) added a comment.Jan 13 2016, 11:19 AM

No need to touch existing tests in this patch, could happen as a separate change. But some tests are failing here:

[  FAILED  ] 4 tests, listed below:
[  FAILED  ] path_util.PathUtilSplitNameNumWithoutDelimiter
[  FAILED  ] path_util.PathUtilSplitNameNumMultipleNumbers
[  FAILED  ] path_util.PathUtilSplitNameNumMultipleNumbersAndDelimiters
[  FAILED  ] path_util.PathUtilPathFrameRangeTooFewHashes
Michał Ziobro (Muchomor) added a comment.Jan 13 2016, 11:13 PM

Hmm, all tests are passed on my build.
Could you send me full output from these four tests and definition of functions which not pass?
(I'm using quite fresh code, just would like to know they are same surely.)

Michał Ziobro (Muchomor) updated this revision to Diff 5870.Jan 18 2016, 7:49 PM
Michał Ziobro (Muchomor) edited edge metadata.

Huh, buffer were too short.
Now everything should be correct.

Michał Ziobro (Muchomor) added a task: T41252: BLI_path_util_test.cc TODO's.Jan 28 2016, 6:17 PM
Campbell Barton (campbellbarton) removed a reviewer: Campbell Barton (campbellbarton).Aug 11 2016, 6:07 AM
Campbell Barton (campbellbarton) removed a subscriber: Campbell Barton (campbellbarton).

Revision Contents
Changeset List

PathSize
tests/
gtests/
blenlib/
753 lines

Diff 5870

View Options

tests/gtests/blenlib/BLI_path_util_test.cc

Loading...