Differential D16819

Fix T103313: Resolve shader compilation failures when enabling GPU workarounds.
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Dec 20 2022, 11:01 AM.

Tags

None

Subscribers

Michael Parkin-White (MichaelPW)

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T103313: Regression: Crash on EEVEE when launch with --debug-gpu-force-workarounds
T96261: Metal Viewport

Commits

rBdedca2c9948a: Fix T103313: Resolve shader compilation failures when enabling GPU workarounds.

Summary

A number of paths resulted in compilation errors after porting EEVEE to use Create-Info. Namely the fallback path for cubemap support. A number of other strict compilation failures regarding format comparison also required fixing when this mode is enabled.

Authored by Apple: Michael Parkin-White

Diff Detail

Repository

Branch

viewport_commits/Fix_T103313_flat

Build Status

Buildable 25100
Build 25100: arc lint + arc unit

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Dec 20 2022, 11:01 AM

Jason Fielder (jason_apple) created this revision.

Harbormaster completed remote builds in B25100: Diff 58758.Dec 20 2022, 11:01 AM

Clément Foucault (fclem) accepted this revision.Dec 20 2022, 11:22 AM

This revision is now accepted and ready to land.Dec 20 2022, 11:22 AM

Michael Parkin-White (MichaelPW) added a task: T103313: Regression: Crash on EEVEE when launch with --debug-gpu-force-workarounds.Dec 20 2022, 2:09 PM

Closed by commit rBdedca2c9948a: Fix T103313: Resolve shader compilation failures when enabling GPU workarounds. (authored by Jason Fielder (jason_apple), committed by Clément Foucault (fclem)). · Explain WhyDec 20 2022, 2:22 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBdedca2c9948a: Fix T103313: Resolve shader compilation failures when enabling GPU workarounds..

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

shaders/

cubemap_lib.glsl

11 lines

shadow_vert.glsl

2 lines

surface_vert.glsl

2 lines

eevee_next/

shaders/

eevee_attributes_lib.glsl

2 lines

overlay/

shaders/

overlay_edit_mesh_common_lib.glsl

6 lines

overlay_edit_mesh_vert.glsl

4 lines

overlay_edit_uv_edges_vert.glsl

4 lines

overlay_edit_uv_faces_vert.glsl

4 lines

overlay_edit_uv_verts_vert.glsl

4 lines

overlay_motion_path_point_vert.glsl

2 lines

gpu/

shaders/

gpu_shader_2D_nodelink_vert.glsl

8 lines

gpu_shader_keyframe_shape_frag.glsl

18 lines

metal/

mtl_shader_defines.msl

3 lines

opengl/

glsl_shader_defines.glsl

7 lines

Diff 58758

source/blender/draw/engines/eevee/shaders/cubemap_lib.glsl

Loading...

source/blender/draw/engines/eevee/shaders/shadow_vert.glsl

Loading...

source/blender/draw/engines/eevee/shaders/surface_vert.glsl

Loading...

source/blender/draw/engines/eevee_next/shaders/eevee_attributes_lib.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_common_lib.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_vert.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_edit_uv_edges_vert.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_edit_uv_faces_vert.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_edit_uv_verts_vert.glsl

Loading...

source/blender/draw/engines/overlay/shaders/overlay_motion_path_point_vert.glsl

Loading...

source/blender/gpu/shaders/gpu_shader_2D_nodelink_vert.glsl

Loading...

source/blender/gpu/shaders/gpu_shader_keyframe_shape_frag.glsl

Loading...

source/blender/gpu/shaders/metal/mtl_shader_defines.msl

Loading...

source/blender/gpu/shaders/opengl/glsl_shader_defines.glsl

Loading...