Curves editmode: add existing selection operators and domain
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 21 2022, 3:35 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Dalai Felinto (dfelinto)

Maniphest Tasks

T101890: Curves editmde: support selection operators from sculptmode

Summary

This moves the selection operators from sculpt_curves to curves and
exposes them (along proper keymap handling) to the UI.

NOTE: undo/redo is not usable yet (since curves editmode is a "real" editmode which is excluded on purpose from MemFile undo). So a special UndoType needs to be implemented (possibly falling back to MemFile undo) or proper exceptions have to be put in place for editmode when curves are in play. I have a hack locally in place which then works fine for undo/redo -- but like I said, this needs to be properly done and is for another patch.

NOTE: documentation for selection probably has to be adjusted as well then to take into account editmode as well.

Diff Detail

Repository

rB Blender

Branch

T101890 (branched from master)

Build Status

Buildable 25121
Build 25121: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Dec 21 2022, 3:35 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B25121: Diff 58799.Dec 21 2022, 3:35 PM

Philipp Oeser (lichtwerk) added projects: Nodes & Physics, User Interface.Dec 21 2022, 3:36 PM

Will create a task for the Undo integration as well.

Thanks for continuing the work on this!

In D16057 and related conversations we were settling on a design where the selection can be stored as a float or boolean attribute.
Edit mode would just write 0.0/false or 1.0/true, depending on the type. Any value greater than zero is considered selected.
Sculpt mode can also "upgrade" the selection attribute and write any float value in [0.0,1.0].

If it's okay with you, I think it would make sense to commit that first, then move code as necessary.

In D16835#458635, @Hans Goudey (HooglyBoogly) wrote:

Thanks for continuing the work on this!

In D16057 and related conversations we were settling on a design where the selection can be stored as a float or boolean attribute.
Edit mode would just write 0.0/false or 1.0/true, depending on the type. Any value greater than zero is considered selected.
Sculpt mode can also "upgrade" the selection attribute and write any float value in [0.0,1.0].

If it's okay with you, I think it would make sense to commit that first, then move code as necessary.

Yep, that would make sense. Will put this on hold for now then.

Falk David (filedescriptor) mentioned this in D17047: Curves: Edit mode selection operators.Thu, Jan 19, 5:51 PM

abandon in favor of D17047