Page MenuHome
Differential D16846

Geometry Node: Geometry socket supported types tooltip without computing
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Dec 22 2022, 3:13 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rBd45ad0acd344: Geometry Nodes: Show supported geometry types tooltip without computing
Summary

Socket declarations exist all the time and it would be useful to use them for tooltips at all times, not just when there is a computed log.

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Dec 22 2022, 3:13 PM
Iliya Katueshenock (Moder) created this revision.
Hans Goudey (HooglyBoogly) added a comment.Dec 22 2022, 4:01 PM

This is a nice improvement, thanks.

source/blender/editors/space_node/node_draw.cc
1052–1053

I guess these dynamic casts will just fail if the pointer is null?

1067

This seems a little clearer/simpler to me

Iliya Katueshenock (Moder) added inline comments.Dec 22 2022, 4:03 PM
source/blender/editors/space_node/node_draw.cc
1052–1053

If the value of v is a null pointer value in the pointer case, the result is the null pointer value of type R.

I checked it on the stackoverflow specifically

Iliya Katueshenock (Moder) updated this revision to Diff 58826.Dec 22 2022, 4:07 PM
Iliya Katueshenock (Moder) marked an inline comment as done.
Hans Goudey (HooglyBoogly) accepted this revision.Dec 22 2022, 4:11 PM
This revision is now accepted and ready to land.Dec 22 2022, 4:11 PM
Iliya Katueshenock (Moder) added a child revision: D16794: Geometry Node: Multi input socket tooltip.Dec 22 2022, 4:30 PM
Iliya Katueshenock (Moder) added a comment.Dec 30 2022, 9:52 AM

Haven't tested yet, definitely need to merge with master after change in message about unlogged tooltip

Iliya Katueshenock (Moder) updated this revision to Diff 58986.Jan 1 2023, 2:47 PM
  • Merge master
Jacques Lucke (JacquesLucke) accepted this revision.Jan 2 2023, 4:37 PM
Iliya Katueshenock (Moder) updated this revision to Diff 59466.Sun, Jan 15, 7:21 PM
  • Merge master
Closed by commit rBd45ad0acd344: Geometry Nodes: Show supported geometry types tooltip without computing (authored by Iliya Katueshenock (Moder), committed by Hans Goudey (HooglyBoogly)). · Explain WhyWed, Jan 18, 2:44 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBd45ad0acd344: Geometry Nodes: Show supported geometry types tooltip without computing.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
50 lines

Diff 59466

View Options

source/blender/editors/space_node/node_draw.cc

Loading...