Paths

Table of Contentst

Differential D16853

Fix T103426: Crash on Insert Keyframe
ClosedPublic
Actions

Authored by Eimear Crotty (eimearc) on Dec 23 2022, 10:16 AM.

Details

Reviewers

Clément Foucault (fclem)

Group Reviewers

EEVEE & Viewport

Maniphest Tasks

T103426: Regression: Crash on Insert Keyframe

Commits

rBa521960fddf2: Fix T103426: Crash on Insert Keyframe

Summary

Add required additional_info to shader using gpu_shader_point_uniform_color_aa_frag.glsl. This is the only other reference to the shader which requires the additional_info to be added.

Diff Detail

Repository

rB Blender

Branch

fix-T103426 (branched from master)

Build Status

Buildable 25141
Build 25141: arc lint + arc unit

Event Timeline

Eimear Crotty (eimearc) requested review of this revision.Dec 23 2022, 10:16 AM

Eimear Crotty (eimearc) created this revision.

Harbormaster completed remote builds in B25141: Diff 58846.Dec 23 2022, 10:16 AM

Eimear Crotty (eimearc) edited the summary of this revision. (Show Details)Dec 23 2022, 10:18 AM

Eimear Crotty (eimearc) added a reviewer: EEVEE & Viewport.

Eimear Crotty (eimearc) added a project: EEVEE & Viewport.

Eimear Crotty (eimearc) added a task: T103426: Regression: Crash on Insert Keyframe.

Clément Foucault (fclem) accepted this revision.Dec 23 2022, 11:00 AM

This revision is now accepted and ready to land.Dec 23 2022, 11:00 AM

In order to avoid surprise like theses, building with WITH_GPU_BUILDTIME_SHADER_BUILDER option on will test all shader compilation at compile time.

Closed by commit rBa521960fddf2: Fix T103426: Crash on Insert Keyframe (authored by Eimear Crotty (eimearc), committed by Clément Foucault (fclem)). · Explain WhyDec 23 2022, 11:40 AM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBa521960fddf2: Fix T103426: Crash on Insert Keyframe.

Thanks for the suggestion @Clément Foucault (fclem), I'll do that from now on.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

infos/

gpu_shader_2D_point_uniform_size_uniform_color_aa_info.hh

1 line

Diff 58846

View Options

source/blender/gpu/shaders/infos/gpu_shader_2D_point_uniform_size_uniform_color_aa_info.hh

Fix T103426: Crash on Insert KeyframeClosedPublicActions