Page MenuHome
Differential D16854

Fix T103011: custom data layers aren't copied when using Boolean
ClosedPublic
Actions

Authored by Jamell Moore (JamellMoore) on Dec 23 2022, 12:07 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T103011: Regression: Boolean modifier create uncorrect weight attribute for bevel modifier
Commits
rBa7cec5a4dbfb: Fix T103011: Exact boolean skips copying edge custom data layers
Summary

Fix T103011: custom data layers aren't copied when using Boolean

When converting from imesh to mesh for the final result, custom
data should be copied from ALL operands including the main mesh

As an added bonus users will now have attributes correctly
preserved/copied when using the Mesh Boolean node.

Diff Detail

Repository
rB Blender
Branch
Fix-T103011-no-bevel-weights-from-boolean-mod (branched from master)
Build Status
Buildable 25144
Build 25144: arc lint + arc unit

Event Timeline

Jamell Moore (JamellMoore) requested review of this revision.Dec 23 2022, 12:07 PM
Jamell Moore (JamellMoore) created this revision.
Harbormaster completed remote builds in B25144: Diff 58852.Dec 23 2022, 12:07 PM
Jamell Moore (JamellMoore) edited the summary of this revision. (Show Details)Dec 23 2022, 12:09 PM
Jamell Moore (JamellMoore) added a task: T103011: Regression: Boolean modifier create uncorrect weight attribute for bevel modifier.
Jamell Moore (JamellMoore) updated this revision to Diff 58854.Dec 23 2022, 12:44 PM
  • Merge the vert, loop and face data from all meshes too
Harbormaster completed remote builds in B25145: Diff 58854.Dec 23 2022, 12:44 PM
Hans Goudey (HooglyBoogly) added inline comments.Dec 26 2022, 8:40 PM
source/blender/blenkernel/intern/mesh_boolean_convert.cc
673

This change shouldn't be necessary for the reason mentioned in the comment above. But that comment doesn't apply to edge custom data, so that looks right.

Hans Goudey (HooglyBoogly) accepted this revision.Dec 26 2022, 8:41 PM
This revision is now accepted and ready to land.Dec 26 2022, 8:41 PM
Closed by commit rBa7cec5a4dbfb: Fix T103011: Exact boolean skips copying edge custom data layers (authored by Jamell Moore (JamellMoore), committed by Hans Goudey (HooglyBoogly)). · Explain WhyDec 26 2022, 8:44 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBa7cec5a4dbfb: Fix T103011: Exact boolean skips copying edge custom data layers.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines

Diff 58852

View Options

source/blender/blenkernel/intern/mesh_boolean_convert.cc

Loading...