Details

Reviewers

Matias Mendiola (mendio)
Campbell Barton (campbellbarton)
Aleš Jelovčan (frogstomp)
Daniel Martinez Lara (pepeland)
Brecht Van Lommel (brecht)

Commits

rB0fb12a9c2ebc: GPencil: Fix size difference between radial control and Brush size

Summary

Due an internal scale of the brush size done by grease pencil
draw tool (this scale factor cannot be removed), the size of the
radial control is not equal to the actual stroke thickness and
this makes the radial size displayed useless.

This patch adds a new property that allows to pass the
path of the tool path and this value is used to apply
the correct scale to the radial size.

Note: The size of the Brush while is not changing was fixed also in other patch. The old version was captured without this patch and the display size of the cursor is not showing real stroke size (see: D16851)

Before the patch:

After the patch:

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Dec 26 2022, 11:33 AM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B25155: Diff 58894.Dec 26 2022, 11:33 AM

@Brecht Van Lommel (brecht) Not sure if you must review this patch or not. I set as reviewer to @Campbell Barton (campbellbarton) because was not sure if he is in charge of this area. Fell free to change reviewers to the right ones.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Dec 26 2022, 11:40 AM

Antonio Vazquez (antoniov) added subscribers: Aleš Jelovčan (frogstomp), Sietse Brouwer (SietseB).

GPencil: Adjust scale factor

Harbormaster completed remote builds in B25156: Diff 58895.Dec 26 2022, 3:28 PM

GPencil: Rename prop

Harbormaster completed remote builds in B25157: Diff 58896.Dec 26 2022, 3:33 PM

The patch needs some changes because now there are problems with the zoom factor.

GPencil: Apply zoom to cursor size

Harbormaster completed remote builds in B25158: Diff 58898.Dec 26 2022, 5:42 PM

Matias Mendiola (mendio) accepted this revision.Dec 26 2022, 6:38 PM

This revision is now accepted and ready to land.Dec 26 2022, 6:38 PM

Aleš Jelovčan (frogstomp) awarded a token.Dec 26 2022, 6:45 PM

Tested, works as expected, thanks for the fix!
Really makes strokes more predictable

The patch works well now, it's a long awaited feature for Grease Pencil.
Now the F keyboard shortcut works as it always should

Yes, totally agree, it's a long awaited feature

Daniel Martinez Lara (pepeland) accepted this revision.Dec 26 2022, 11:08 PM

Merge branch 'master' into temp-gp-radial-size

Harbormaster completed remote builds in B25161: Diff 58907.Dec 27 2022, 10:33 AM

Super useful!! I've been waiting for a long time for this feature. It was really unconfortable having to do test strokes before drawing to see if you had the proper brush size.

Thank you so much!

Amelie Fondevilla (afonde) awarded a token.Jan 3 2023, 4:42 PM

If you're going to add a hardcoded exception for grease pencil in radial_control_set_initial_mouse anyway, I don't see any point to adding a tool_path property and having the keymap be affected by this. ED_gpencil_cursor_radius already accesses the brush through the context also.

Instead add a utility function like ED_gpencil_radial_control_scale(C, rc->ptr->id_owner, rc->prop, ..) that checks if the ID and property are the active grease pencil brush and size.

This revision now requires changes to proceed.Jan 4 2023, 1:32 PM

GPencil: Refactor Radial Control size after patch review

Harbormaster completed remote builds in B25230: Diff 59079.Jan 4 2023, 4:18 PM

Cleanup header files

Harbormaster completed remote builds in B25231: Diff 59080.Jan 4 2023, 4:19 PM

Brecht Van Lommel (brecht) requested changes to this revision.Jan 4 2023, 4:51 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/windowmanager/intern/wm_operators.c
2286	You can't assume this is a brush, and that it's modifying the size. You can include `RNA_property_types.h` and then do something like this: if (rc->ptr.owner_id && ID(rc->ptr.owner_id) == ID_BR && rc->prop == &rna_Brush_size) { ... }

This revision now requires changes to proceed.Jan 4 2023, 4:51 PM

Check ID type before check radius

I didn't use ID as you proposed because I couldn't include RNA_property_types.h. I have used GS which does the same

Harbormaster completed remote builds in B25236: Diff 59089.Jan 4 2023, 6:08 PM

Antonio Vazquez (antoniov) marked an inline comment as done.Jan 4 2023, 6:09 PM

Antonio Vazquez (antoniov) added inline comments.