Fix T103555: File output node saving to the wrong folder
AbandonedPublic
Actions

Authored by Alaska (Alaska) on Dec 30 2022, 9:22 PM.

Details

Reviewers

Maniphest Tasks

T103555: File output nodes don't use the extra slash on the end unless there is a file sub path leading to incorrect file locations

Commits

rB77e8e73ed9a1: Fix T103555: File output node saving to the wrong folder

Summary

Regression in [0], caused by reliance on BLI_join_dirfile adding a trailing slash when an empty file was passed in.

[0]: 9f6a045e23cf4ab132ef78eeaf070bd53d0c509f

Diff Detail

Repository

rB Blender

Branch

fix_file_output (branched from master)

Build Status

Buildable 25178
Build 25178: arc lint + arc unit

Event Timeline

Alaska (Alaska) requested review of this revision.Dec 30 2022, 9:22 PM

Alaska (Alaska) created this revision.

Harbormaster completed remote builds in B25178: Diff 58966.Dec 30 2022, 9:22 PM

Alaska (Alaska) added a task: T103555: File output nodes don't use the extra slash on the end unless there is a file sub path leading to incorrect file locations.Dec 30 2022, 9:23 PM

Philipp Oeser (lichtwerk) mentioned this in T103555: File output nodes don't use the extra slash on the end unless there is a file sub path leading to incorrect file locations.Jan 2 2023, 2:23 PM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Jan 4 2023, 11:05 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Campbell Barton (campbellbarton) mentioned this in rB77e8e73ed9a1: Fix T103555: File output node saving to the wrong folder.Jan 4 2023, 11:08 AM

Closing diff since it has been committed.

Alaska (Alaska) added a commit: rB77e8e73ed9a1: Fix T103555: File output node saving to the wrong folder.Jan 4 2023, 12:23 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

compositor/

nodes/

COM_OutputFileNode.cc

8 lines

Diff 58966

View Options

source/blender/compositor/nodes/COM_OutputFileNode.cc

Fix T103555: File output node saving to the wrong folderAbandonedPublicActions