Fix: sort link indices in multi input sockets incorrect
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Dec 31 2022, 3:45 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Commits

rB433d436b84ea: Fix: sort link indices in multi input sockets incorrect

Summary

For some reason I don't understand, the dragged link is sorted across all the node's multi-input sockets.
This leads to problems when there are multiple sockets to sort.
With this patch, I'm making the feature work more directional.

Video illustration of the problem:

Discovered during development: T103457: Attribute Map node

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Dec 31 2022, 3:45 PM

Iliya Katueshenock (Moder) created this revision.

Merge master

Thanks for the patch.

This revision is now accepted and ready to land.Jan 4 2023, 10:36 PM

Closed by commit rB433d436b84ea: Fix: sort link indices in multi input sockets incorrect (authored by Iliya Katueshenock (Moder), committed by Hans Goudey (HooglyBoogly)). · Explain WhyJan 4 2023, 10:39 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB433d436b84ea: Fix: sort link indices in multi input sockets incorrect.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_node/

node_relationships.cc

37 lines

Diff 59093

View Options

source/blender/editors/space_node/node_relationships.cc

Fix: sort link indices in multi input sockets incorrectClosedPublicActions