Fix T103412: Resolve selection outline rendering with Metal backend on AMD.
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Jan 6 2023, 3:44 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T96261: Metal Viewport
T103412: 3.5 Metal Backend Selected- Object selected Outline Missing

Commits

rBcd2926fb05b0: Fix T103412: Resolve selection outline rendering with Metal backend on AMD.

Summary

AMD GPUs do not appear to produce consistent results with other GPUs when using textureGather in the Metal backend. Disabling for now to ensure correct function of outline rendering.

This may require an additional sub-pixel offset in the texture sampling calls, to achieve correct behaviour.

Authored by Apple: Michael Parkin-White

Ref T103412
Ref T96261

Diff Detail

Repository: rB Blender

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Jan 6 2023, 3:44 PM

Jason Fielder (jason_apple) created this revision.

Harbormaster completed remote builds in B25263: Diff 59175.Jan 6 2023, 3:44 PM

Francesco Siddi (fsiddi) awarded a token.Jan 6 2023, 7:19 PM

Fine with the approach. Just suggesting a better codestyle.

source/blender/gpu/metal/mtl_shader_generator.mm
584–592	And make the string not `const`. Keep it easier to read.

This revision now requires changes to proceed.Jan 7 2023, 5:15 PM

Addressed feedback

Harbormaster completed remote builds in B25354: Diff 59409.Fri, Jan 13, 2:02 PM

Clément Foucault (fclem) accepted this revision.Mon, Jan 16, 1:34 AM

This revision is now accepted and ready to land.Mon, Jan 16, 1:34 AM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Tue, Jan 17, 4:06 AM

NOTE: This should not have any direct dependencies and should be able to land directly in master. As there are changes to mtl_shader_generator.mm, Viewport compositor compute patch and GLSL translation optimization patches will likely need rebasing after this has landed.

Closed by commit rBcd2926fb05b0: Fix T103412: Resolve selection outline rendering with Metal backend on AMD. (authored by Jason Fielder (jason_apple), committed by Clément Foucault (fclem)). · Explain WhyMon, Jan 23, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBcd2926fb05b0: Fix T103412: Resolve selection outline rendering with Metal backend on AMD..