Nodes: Avoid small allocations for internal links
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jan 9 2023, 11:45 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rB05ddc7daa23e: Nodes: Avoid small allocations for internal links

Summary

Since internal links are only runtime data, we have the flexibility to
allocating every link individually. Instead we can store links directly
in the node runtime vector. This allows avoiding many small allocations
when copying and changing node trees.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jan 9 2023, 11:45 PM

Hans Goudey (HooglyBoogly) created this revision.

I wonder if we could try not to use bNodeLink at all instead.

That would be nice. The RNA changes would be more complicated though. Maybe it makes sense to commit this first? I can look at that next.

Actually, if we did that we might want to change the RNA API by adding a separate RNA type for internal links. So it probably should be a separate commit.

Jacques Lucke (JacquesLucke) accepted this revision.Jan 10 2023, 12:47 AM

This revision is now accepted and ready to land.Jan 10 2023, 12:47 AM

Closed by commit rB05ddc7daa23e: Nodes: Avoid small allocations for internal links (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJan 10 2023, 5:32 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB05ddc7daa23e: Nodes: Avoid small allocations for internal links.

Hans Goudey (HooglyBoogly) mentioned this in T102607: Breaking nodes API changes for 4.0.Mon, Jan 16, 6:16 PM