Differential D16997

Fix T103850: Avoid using components that can contain null pointer
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Jan 13 2023, 6:55 PM.

Tags

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)
Wannes Malfait (Wannes)

Maniphest Tasks

T103850: Regression: Geometry Node: Crash: Empty meshes -> Join Geometry -> Convex Hull

Commits

rBe35053d36906: Fix T103850: Convex hull node crash with empty geometry components

Summary

Getting attibute should avoid trying to do it for a null mesh.
This fix bypasses working with components.

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Jan 13 2023, 6:55 PM

Iliya Katueshenock (Moder) created this revision.

Iliya Katueshenock (Moder) added a task: T103850: Regression: Geometry Node: Crash: Empty meshes -> Join Geometry -> Convex Hull.

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)Jan 13 2023, 6:57 PM

Looks good, thanks.

This revision is now accepted and ready to land.Jan 13 2023, 6:58 PM

Closed by commit rBe35053d36906: Fix T103850: Convex hull node crash with empty geometry components (authored by Iliya Katueshenock (Moder), committed by Hans Goudey (HooglyBoogly)). · Explain WhyJan 13 2023, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBe35053d36906: Fix T103850: Convex hull node crash with empty geometry components.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_convex_hull.cc

26 lines

Diff 59423

source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc

Loading...