Page MenuHome
Differential D17001

Fix: Build failure due to type conversion
AbandonedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Sat, Jan 14, 8:11 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Summary

In rB3a3d9488a163 CustomData_get_layer is marked as const
which results in build failure on windows due to type conversion at
BKE_mesh_validate_all_customdata() function call

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Sat, Jan 14, 8:11 AM
Pratik Borhade (PratikPB2123) created this revision.
Iliya Katueshenock (Moder) awarded a token.Sat, Jan 14, 1:12 PM
Martijn Versteegh (Baardaap) added a subscriber: Martijn Versteegh (Baardaap).EditedSat, Jan 14, 1:16 PM

Would it not be better to make BKE_mesh_validate_arrays() take a const MFace * ? A validate function doesn't need to write to the faces I'd guess.

Or is that impossible?

edit: looking at the comments on that _validate() function that's probably impossible...

Iliya Katueshenock (Moder) mentioned this in rB8126d92073b2: Cleanup: fix compile error in debug build.Sat, Jan 14, 2:20 PM
Martijn Versteegh (Baardaap) added a comment.Sat, Jan 14, 2:21 PM

In the chat @Hans Goudey (HooglyBoogly) mentioned this as the correct fix so I guess it could just be landed.

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Sat, Jan 14, 2:23 PM

rB8126d92073b222ba6647c7988e728895ab3f14a8

Pratik Borhade (PratikPB2123) abandoned this revision.Sun, Jan 15, 4:56 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines

Diff 59438

View Options

source/blender/blenkernel/intern/mesh_runtime.cc

Loading...