Differential D17003

Fix T103632: Single point trim should sample curve end point correctly
ClosedPublic
Actions

Authored by Mattias Fredriksson (Osares) on Jan 15 2023, 12:19 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T103632: Regression: Trim Curve at 100% Causing Jumping of vertices away from the original position

Commits

rBc55767b32ee1: Fix T103632: Single point trim samples curve end point incorrectly

Summary

Trim erronously samples the next to last control point when it should sample the last control point on the curve. This only happends when reducing the curve to a single point. These changes should correct the behavior.

Related Issue:

T103632

Result:

Diff Detail

Repository

rB Blender

Branch

trim_end_point_sample_bug (branched from master)

Build Status

Buildable 25371
Build 25371: arc lint + arc unit

Event Timeline

Mattias Fredriksson (Osares) requested review of this revision.Jan 15 2023, 12:19 AM

Mattias Fredriksson (Osares) created this revision.

Harbormaster completed remote builds in B25371: Diff 59455.Jan 15 2023, 12:19 AM

Mattias Fredriksson (Osares) retitled this revision from Sample curve end point correctly to Fix T103632: Single point trim should sample curve end point correctly.Jan 15 2023, 12:25 AM

Mattias Fredriksson (Osares) edited the summary of this revision. (Show Details)

Mattias Fredriksson (Osares) added a reviewer: Hans Goudey (HooglyBoogly).

Mattias Fredriksson (Osares) added a project: Geometry Nodes.

Mattias Fredriksson (Osares) edited the summary of this revision. (Show Details)

Iliya Katueshenock (Moder) added a task: T103632: Regression: Trim Curve at 100% Causing Jumping of vertices away from the original position.Jan 15 2023, 12:27 AM

Mattias Fredriksson (Osares) edited the summary of this revision. (Show Details)Jan 15 2023, 12:32 AM

Mattias Fredriksson (Osares) edited the summary of this revision. (Show Details)Jan 15 2023, 12:34 AM