Page MenuHome
Differential D17004

Provide Option for Fill in Grease Pencil Material Popover, Only Show When Enabled
ClosedPublic
Actions

Authored by Kevin C. Burke (blastframe) on Sun, Jan 15, 5:41 AM.

Details

Reviewers
Antonio Vazquez (antoniov)
Matias Mendiola (mendio)
Commits
rBe144af1f7cd3: GPencil: Provide Option for Fill in Material Popover
Summary

The Grease Pencil Material Popover currently has a color picker for the Stroke of a Material using Solid style, but not one for a Fill using Solid style. With the default Grease Pencil Materials, the current popover only shows the Stroke color for the grey "Solid Fill" material (which doesn't have its Stroke enabled) instead of the more useful Fill color.

This patch shows a Stroke color picker when the Material has Stroke enabled and the style is Solid. This is the same for the Fill.

Diff Detail

Repository
rB Blender

Event Timeline

Kevin C. Burke (blastframe) requested review of this revision.Sun, Jan 15, 5:41 AM
Kevin C. Burke (blastframe) created this revision.
Kevin C. Burke (blastframe) edited the summary of this revision. (Show Details)
Kevin C. Burke (blastframe) edited the summary of this revision. (Show Details)Sun, Jan 15, 5:51 AM
Antonio Vazquez (antoniov) added a subscriber: Matias Mendiola (mendio).Tue, Jan 17, 11:43 AM

@Matias Mendiola (mendio) I think this change is logic, but if we have Stroke and Fill, the popover will show both colors. Don't see any problem with that, but I would like to know your opinion.

Antonio Vazquez (antoniov) added a project: BF Blender.Tue, Jan 17, 11:43 AM
Matias Mendiola (mendio) accepted this revision.Tue, Jan 17, 2:21 PM
In D17004#463857, @Antonio Vazquez (antoniov) wrote:

@Matias Mendiola (mendio) I think this change is logic, but if we have Stroke and Fill, the popover will show both colors. Don't see any problem with that, but I would like to know your opinion.

It's Ok for me

This revision is now accepted and ready to land.Tue, Jan 17, 2:21 PM
Closed by commit rBe144af1f7cd3: GPencil: Provide Option for Fill in Material Popover (authored by Kevin C. Burke (blastframe), committed by Antonio Vazquez (antoniov)). · Explain WhyTue, Jan 17, 3:45 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rBe144af1f7cd3: GPencil: Provide Option for Fill in Material Popover.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
8 lines

Diff 59527

View Options

release/scripts/startup/bl_ui/properties_grease_pencil_common.py

Loading...