Paths

Table of Contentst

Differential D17006

Separating strokes creates negative times
ClosedPublic
Actions

Authored by Marc Chéhab (marcluzmedia) on Sun, Jan 15, 5:25 PM.

Tags

Subscribers

None

Details

Reviewers

Antonio Vazquez (antoniov)
Aleš Jelovčan (frogstomp)

Commits

rB9a1f0443cbc3: Fix Unreported: GPencil Separating strokes creates negative times

Summary

Separating strokes using "selected points" didn't take into account that points->time can be 0 and thus created points with negative values in points->time, which should be an impossibility. This patch fixes this in BKE_gpencil_stroke_delete_tagged_points.

Also, it makes the build modifier's new drawspeed immune to (erroneous) negative time values, should they arise in other situations.

Diff Detail

Repository: rB Blender

Event Timeline

Marc Chéhab (marcluzmedia) requested review of this revision.Sun, Jan 15, 5:25 PM

Marc Chéhab (marcluzmedia) created this revision.

removed a printf

Marc Chéhab (marcluzmedia) added a reviewer: Aleš Jelovčan (frogstomp).Sun, Jan 15, 5:42 PM

@Aleš Jelovčan (frogstomp) I don't know if you need to test it...really the fix is very simple.

source/blender/blenkernel/intern/gpencil_geom.cc
3220	instead of the if, you could use `pt->time = max_ff(pt->time - delta, 0.0f);` if the variables are `int` then use `max_ii`

Elegant edit suggested by @Antonio Vazquez (antoniov)

Marc Chéhab (marcluzmedia) marked an inline comment as done.Mon, Jan 16, 11:44 AM

Antonio Vazquez (antoniov) accepted this revision.Mon, Jan 16, 12:01 PM

This revision is now accepted and ready to land.Mon, Jan 16, 12:01 PM

Closed by commit rB9a1f0443cbc3: Fix Unreported: GPencil Separating strokes creates negative times (authored by Marc Chéhab (marcluzmedia), committed by Antonio Vazquez (antoniov)). · Explain WhyMon, Jan 16, 12:15 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB9a1f0443cbc3: Fix Unreported: GPencil Separating strokes creates negative times.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

gpencil_geom.cc

3 lines

gpencil_modifiers/

intern/

MOD_gpencilbuild.c

2 lines

Diff 59475

source/blender/blenkernel/intern/gpencil_geom.cc

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencilbuild.c

Loading...