Page MenuHome
Differential D17008

Fix: Draw: Incorrect culling in the new Draw Manager
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Mon, Jan 16, 12:46 PM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rBb82f7814c4f3: Fix: Draw: Incorrect culling in the new Draw Manager
Summary

ViewCullingData::corners (vec4) was casted to a BoundingBox (vec3), so the frustum corners were uploaded in the wrong format to the GPU.

Now the ViewCullingData::corners are used directly without casting, since the BoundBox API is not really needed.

Diff Detail

Repository
rB Blender

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Mon, Jan 16, 12:46 PM
Miguel Pozo (pragma37) created this revision.
Harbormaster completed remote builds in B25376: Diff 59478.Mon, Jan 16, 12:46 PM
Miguel Pozo (pragma37) added a reviewer: Clément Foucault (fclem).Mon, Jan 16, 12:48 PM
Clément Foucault (fclem) added inline comments.Mon, Jan 16, 1:48 PM
source/blender/draw/intern/draw_view.cc
44

Same here.

99

Prefer using blender::Span<float4> corners(culling_[view_id].corners, ARRAY_SIZE(culling_[view_id].corners));. This adds bound checks on access and allow to iterate over its data.

Miguel Pozo (pragma37) updated this revision to Diff 59491.Mon, Jan 16, 6:26 PM
  • Use Spans
Harbormaster completed remote builds in B25386: Diff 59491.Mon, Jan 16, 6:26 PM
Miguel Pozo (pragma37) marked 2 inline comments as done.Mon, Jan 16, 6:33 PM
Clément Foucault (fclem) accepted this revision.Mon, Jan 16, 6:35 PM
This revision is now accepted and ready to land.Mon, Jan 16, 6:35 PM
Closed by commit rBb82f7814c4f3: Fix: Draw: Incorrect culling in the new Draw Manager (authored by Miguel Pozo (pragma37)). · Explain WhyMon, Jan 16, 6:41 PM
This revision was automatically updated to reflect the committed changes.
Miguel Pozo (pragma37) added a commit: rBb82f7814c4f3: Fix: Draw: Incorrect culling in the new Draw Manager.
Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Tue, Jan 17, 4:41 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
5 lines
58 lines

Diff 59493

View Options

source/blender/draw/intern/draw_view.hh

Loading...
View Options

source/blender/draw/intern/draw_view.cc

Loading...