Page MenuHome
Differential D17017

Fix T103881: Unlink operation crash in Blender File view
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Tue, Jan 17, 11:27 AM.

Details

Reviewers
Philipp Oeser (lichtwerk)
Julian Eisel (Severin)
Maniphest Tasks
T103881: Regression: Blender Crash when unlinking a Collection from Blender File
Commits
rBa3c38667f0f8: Fix T103881: Unlink operation crash in Blender File view
Summary

Similar to rBe97443478e32 and rBe772087ed664, exit early when
texture, collection and world ID has no parent to unlink from.

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Tue, Jan 17, 11:27 AM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) added a project: User Interface.
Pratik Borhade (PratikPB2123) added a task: T103881: Regression: Blender Crash when unlinking a Collection from Blender File.

Similar issue is still present for texture and world material ID. Want me to add both in this patch?

Julian Eisel (Severin) requested changes to this revision.EditedTue, Jan 17, 11:44 AM

This should show an error and not fail silently, otherwise it's confusing to the user. See rBe97443478e32, rB67254ea37cb4.

Besides that looks fine to me.

In D17017#463853, @Pratik Borhade (PratikPB2123) wrote:

Similar issue is still present for texture and world material ID. Want me to add both in this patch?

Don't mind much if you do it in the same patch or separate, but yeah I'd welcome the fixes of course :)

This revision now requires changes to proceed.Tue, Jan 17, 11:44 AM
Pratik Borhade (PratikPB2123) updated this revision to Diff 59518.Tue, Jan 17, 12:08 PM
Pratik Borhade (PratikPB2123) retitled this revision from Fix T103881: Blender Crash when unlinking a Collection from Blender File to Fix T103881: Unlink operation crash in Blender File view.
Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)
Julian Eisel (Severin) requested changes to this revision.Wed, Jan 18, 11:33 AM

"It's not clear which object or object-data it should be unlinked from, there's no object or object-data [...]"
There are no objects or object data involved in the cases here (in most of them at least). Collections are unlinked from the scene or instance empties, worlds from the scene, and textures from freestyle line styles only.

This revision now requires changes to proceed.Wed, Jan 18, 11:33 AM
Pratik Borhade (PratikPB2123) updated this revision to Diff 59618.Thu, Jan 19, 11:10 AM

update warning message

Philipp Oeser (lichtwerk) accepted this revision.Thu, Jan 19, 11:17 AM
Philipp Oeser (lichtwerk) added 1 blocking reviewer(s): Julian Eisel (Severin).
Julian Eisel (Severin) accepted this revision.Thu, Jan 19, 11:20 AM

The line wrapping of the messages is odd, besides that LGTM.
Thanks for working on this!

This revision is now accepted and ready to land.Thu, Jan 19, 11:20 AM
Pratik Borhade (PratikPB2123) updated this revision to Diff 59619.Thu, Jan 19, 11:32 AM

format message

Closed by commit rBa3c38667f0f8: Fix T103881: Unlink operation crash in Blender File view (authored by Pratik Borhade (PratikPB2123)). · Explain WhyThu, Jan 19, 11:36 AM
This revision was automatically updated to reflect the committed changes.
Pratik Borhade (PratikPB2123) added a commit: rBa3c38667f0f8: Fix T103881: Unlink operation crash in Blender File view.
Pratik Borhade (PratikPB2123) added a comment.Thu, Jan 19, 11:37 AM

Thanks for reviewing :)

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_outliner/
42 lines

Diff 59620

View Options

source/blender/editors/space_outliner/outliner_tools.cc

Loading...