Page MenuHome
Differential D17018

Fix T103433: Ensure Metal memory allocator is safe for multi-threaded allocation. Resolves crash when baking indirect lighting.
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Tue, Jan 17, 12:03 PM.

Details

Reviewers
Clément Foucault (fclem)
Jeroen Bakker (jbakker)
Maniphest Tasks
T103433: MacOS Metal GPU backend: Crash when baking indirect lightning
T96261: Metal Viewport
Commits
rB1c672f3d1dae: Fix T103433: Ensure Metal memory allocator is safe for multi-threaded…
Summary

Also applies correct texture usage flag to light bake texture.

Authored by Apple: Michael Parkin-White

Ref T96261

Diff Detail

Repository
rB Blender
Branch
viewport_commits/Fix_T103433_fla
Build Status
Buildable 25397
Build 25397: arc lint + arc unit

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Tue, Jan 17, 12:03 PM
Jason Fielder (jason_apple) created this revision.
Harbormaster completed remote builds in B25397: Diff 59517.Tue, Jan 17, 12:03 PM
Michael Parkin-White (MichaelPW) added a task: T103433: MacOS Metal GPU backend: Crash when baking indirect lightning.Tue, Jan 17, 2:31 PM
Jason Fielder (jason_apple) added a child revision: D17019: Metal: Improve command buffer handling and workload scheduling..Tue, Jan 17, 2:47 PM
Jeroen Bakker (jbakker) accepted this revision.Fri, Jan 20, 10:49 AM
Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Clément Foucault (fclem).
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).

The patch seems to work as expected.

Clément Foucault (fclem) accepted this revision.Fri, Jan 20, 12:43 PM
This revision is now accepted and ready to land.Fri, Jan 20, 12:43 PM
Michael Parkin-White (MichaelPW) added a comment.Mon, Jan 23, 12:23 PM
NOTE: No dependencies on other patches, should be able to land directly against master. Please let me know if this needs re-basing.
Closed by commit rB1c672f3d1dae: Fix T103433: Ensure Metal memory allocator is safe for multi-threaded… (authored by Jason Fielder (jason_apple), committed by Clément Foucault (fclem)). · Explain WhyMon, Jan 23, 5:46 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rB1c672f3d1dae: Fix T103433: Ensure Metal memory allocator is safe for multi-threaded….

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
3 lines
gpu/
metal/
10 lines
17 lines

Diff 59517

View Options

source/blender/draw/engines/eevee/eevee_lightcache.c

Loading...
View Options

source/blender/gpu/metal/mtl_memory.hh

Loading...
View Options

source/blender/gpu/metal/mtl_memory.mm

Loading...