Metal: Improve command buffer handling and workload scheduling.
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Tue, Jan 17, 2:47 PM.

Details

Reviewers

Maniphest Tasks

T96261: Metal Viewport
T103742: MacOS Metal GPU backend: slower viewport performance than OpenGL and flickering window animation when switching applications

Commits

rB84c25fdcaa42: Metal: Improve command buffer handling and workload scheduling.

Summary

Improve handling for cases where maximum in-flight command buffer count is exceeded. This can occur during light-baking operations. Ensures the application handles this gracefully and also improves workload pipelining by situationally stalling until GPU work has completed, if too much work is queued up.

This may have a tangible benefit for T103742 by ensuring Blender does not queue up too much GPU work.

Authored by Apple: Michael Parkin-White

Ref T96261
Ref T103742
Depends on D17018

Diff Detail

Repository

rB Blender

Branch

viewport_commits/MetalCommandBufferSubmission

Build Status

Buildable 25402
Build 25402: arc lint + arc unit

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Tue, Jan 17, 2:47 PM

Jason Fielder (jason_apple) created this revision.

Harbormaster completed remote builds in B25402: Diff 59523.Tue, Jan 17, 2:47 PM

Clément Foucault (fclem) accepted this revision.Mon, Jan 23, 10:50 AM

This revision is now accepted and ready to land.Mon, Jan 23, 10:50 AM

NOTE: Should not have any explicit dependencies on other patches, and should be able to land directly into master. Please let me know if this needs rebasing.

Closed by commit rB84c25fdcaa42: Metal: Improve command buffer handling and workload scheduling. (authored by Jason Fielder (jason_apple), committed by Clément Foucault (fclem)). · Explain WhyMon, Jan 23, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB84c25fdcaa42: Metal: Improve command buffer handling and workload scheduling..