Cycles: Optionally output luminance from the shader evaluation kernel
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Dec 30 2015, 9:31 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Lukas Stockner (lukasstockner97)
Martijn Berger (juicyfruit)

Commits

rC522ba3d31b18: Optionally output luminance from the shader evaluation kernel
rBS3918c8b9a52a: Cycles: Optionally output luminance from the shader evaluation kernel
rB3918c8b9a52a: Cycles: Optionally output luminance from the shader evaluation kernel

Summary

This makes it possible to move some parts of evaluation from host to the device
and hopefully reduce memory usage by avoid having full RGBA buffer on the host.

This makes it possible to implement D1377 in a way which does not require cast
magic.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) updated this revision to Diff 5683.Dec 30 2015, 9:31 AM

Sergey Sharybin (sergey) retitled this revision from to Cycles: Optionally output luminance from the shader evaluation kernel.

Sergey Sharybin (sergey) added reviewers: Brecht Van Lommel (brecht), Martijn Berger (juicyfruit), Lukas Stockner (lukasstockner97).

Sergey Sharybin (sergey) updated this object.

Sergey Sharybin (sergey) mentioned this in D1377: Cycles: Moved the background map averaging into the kernel, saving some memory.Dec 30 2015, 9:33 AM

Brecht Van Lommel (brecht) accepted this revision.Dec 30 2015, 1:27 PM

Brecht Van Lommel (brecht) edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2015, 1:27 PM

Well, that will work as well - I tried to avoid large-scale changes in D1377, but this is probably the cleaner approach.

It's better to not be afraid of a larger-scale changes and keep code clear and robust. Will commit the patch to master now, then you can easily update D1377.